HendSame commented on pull request #7554:
URL: https://github.com/apache/skywalking/pull/7554#issuecomment-906022309
@kezhenxu94 @wu-sheng
https://github.com/apache/skywalking/pull/7554#discussion_r695905400
About :
```
Why use sampleRate for default and rate for services? I think it better to
be consistent.
```
As `agent-analyzer.default.sampleRate` use `sampleRate`, I think both use
`sampleRate` if want to be consistent.
@kezhenxu94
About :
```
default:
sampleRate: 10000
duration: -1
service1:
sampleRate: 1000
duration: 20000
name2:
sampleRate: 2000
duration: 30000
```
I don't think so. It looks like layers is not clear. After all, the
`default ` and `specific service` is two different dimensions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
