kezhenxu94 commented on pull request #7495: URL: https://github.com/apache/skywalking/pull/7495#issuecomment-908844308
> We don't know, but when you dig deeper, you will notice. BanyanDB Java client is not only for providing client implementation, it is scoping the client proto files. All those proto files in the server side are not all cared of by the client. We show how to integrate. If end users will(long future will) run some integration, they could use the proto files in client folder, and go further. IMHO that's our responsibility to make it clear in repo apache/skywalking-banyandb or apache/skywalking-banyandb-api (instead of in banyandb-java-client repo) what are client side `.proto` files and what are server side `.proto` files, even we have Java client, it should not take the responsibility to scope the client `.proto` files, after all, users may use other programming languages. > That is and only for professional cross open source projects integration. Like we analysis Envoy protobuf, and have our complex solution for mesh observability. But that is a very rare case and for a small subset of all open source users. We need those proto, and we need more. That's my point, BanyanDB is an APM-specific database, not general-purpose database, I just thought that there won't be many ordinary users integrate it. I'm totally OK to have `banyandb-java-client` repo, just wanted to raise the discussion above as soon as I notice it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
