wu-sheng commented on a change in pull request #7632:
URL: https://github.com/apache/skywalking/pull/7632#discussion_r700033858
##########
File path:
oap-server/server-configuration/configuration-nacos/src/main/java/org/apache/skywalking/oap/server/configuration/nacos/NacosConfigWatcherRegister.java
##########
@@ -92,8 +91,35 @@ public NacosConfigWatcherRegister(NacosServerSettings
settings) throws NacosExce
@Override
public Optional<GroupConfigTable> readGroupConfig(final Set<String> keys) {
- // TODO: implement readGroupConfig
- return Optional.empty();
+ Set<String> keys1 = new HashSet<>();
+ keys1.add("test-module.default.testKeyGroup");
Review comment:
What is this? Legacy testing codes?
##########
File path:
oap-server/server-configuration/configuration-nacos/src/main/java/org/apache/skywalking/oap/server/configuration/nacos/NacosConfigWatcherRegister.java
##########
@@ -92,8 +91,35 @@ public NacosConfigWatcherRegister(NacosServerSettings
settings) throws NacosExce
@Override
public Optional<GroupConfigTable> readGroupConfig(final Set<String> keys) {
- // TODO: implement readGroupConfig
- return Optional.empty();
+ Set<String> keys1 = new HashSet<>();
Review comment:
```suggestion
```
What is this?
##########
File path:
oap-server/server-configuration/configuration-nacos/src/main/java/org/apache/skywalking/oap/server/configuration/nacos/NacosConfigWatcherRegister.java
##########
@@ -92,8 +91,35 @@ public NacosConfigWatcherRegister(NacosServerSettings
settings) throws NacosExce
@Override
public Optional<GroupConfigTable> readGroupConfig(final Set<String> keys) {
- // TODO: implement readGroupConfig
- return Optional.empty();
+ Set<String> keys1 = new HashSet<>();
+ keys1.add("test-module.default.testKeyGroup");
+
+ GroupConfigTable groupConfigTable = new GroupConfigTable();
+ keys1.forEach(key -> {
Review comment:
`keys1` seems never getting initialized properly, and real `keys` are
never used.
I assume you submitted the local testing codes.
##########
File path:
oap-server/server-configuration/configuration-nacos/src/main/java/org/apache/skywalking/oap/server/configuration/nacos/NacosConfigWatcherRegister.java
##########
@@ -92,8 +91,35 @@ public NacosConfigWatcherRegister(NacosServerSettings
settings) throws NacosExce
@Override
public Optional<GroupConfigTable> readGroupConfig(final Set<String> keys) {
- // TODO: implement readGroupConfig
- return Optional.empty();
+ Set<String> keys1 = new HashSet<>();
+ keys1.add("test-module.default.testKeyGroup");
+
+ GroupConfigTable groupConfigTable = new GroupConfigTable();
+ keys1.forEach(key -> {
Review comment:
Even in this case, the UTs are passed. I think UTs miss some important
cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
