darcydai commented on a change in pull request #17:
URL: https://github.com/apache/skywalking-java/pull/17#discussion_r700713433
##########
File path: test/plugin/scenarios/lettuce-scenario/support-version.list
##########
@@ -16,4 +16,7 @@
5.2.1.RELEASE
5.1.8.RELEASE
-5.0.5.RELEASE
\ No newline at end of file
+5.0.5.RELEASE
+6.0.0.RELEASE
+6.0.5.RELEASE
Review comment:
removed
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/tag/Tags.java
##########
@@ -96,6 +96,8 @@ private Tags() {
*/
public static final StringTag RPC_RESPONSE_STATUS_CODE = new StringTag(18,
"rpc.status_code", true);
+ public static final StringTag SIGNAL_TYPE = new StringTag(19,
"signalType");
Review comment:
removed
##########
File path:
apm-sniffer/apm-sdk-plugin/lettuce-5.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/lettuce/v5/RedisChannelWriterInterceptor.java
##########
@@ -89,22 +105,37 @@ private String getArgsStatement(RedisCommand redisCommand)
{
}
@Override
- public Object afterMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class<?>[] argumentsTypes,
- Object ret) throws Throwable {
- ContextManager.stopSpan();
+ public Object afterMethod(EnhancedInstance objInst, Method method,
Object[] allArguments, Class<?>[] argumentsTypes, Object ret) {
return ret;
}
@Override
- public void handleMethodException(EnhancedInstance objInst, Method method,
Object[] allArguments,
- Class<?>[] argumentsTypes, Throwable t) {
+ public void handleMethodException(EnhancedInstance objInst, Method method,
Object[] allArguments, Class<?>[] argumentsTypes, Throwable t) {
AbstractSpan span = ContextManager.activeSpan();
span.log(t);
Review comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
