wu-sheng commented on pull request #18: URL: https://github.com/apache/skywalking-java/pull/18#issuecomment-912950990
I don't mean the current codes are correct. My keypoints for your changes are 1. We want to avoid reflections in your codes. Are they possible? If not, is it only executing once a new connection created? 2. If the database instance name matter, why don't we change the tag(instance name) value? We are an APM, if information in trace is changed, those should be consistent in metrics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
