kezhenxu94 commented on issue #2935: Add end to end tests URL: https://github.com/apache/skywalking/pull/2935#issuecomment-506945826 > Feedback > > 1. Consider using UUID rather than commit ID, in case of job re-run and parallel e2e tests(should add later) > 2. Verifications are not very clear, you could pass a check with unexpected checked. > 3. Include multiple e2e test cases design in this PR. Don't need to have real mutiple scenario tests, but project structures and design should be there. > 4. Miss verifications about metadata, metrics, and topology. We don't need to verify all, but we at least verify each one of them. > > Basically, I think this e2e test framework is near ready. Hope we could land this as the first of 6.3.0 1. After thinking for a while, I decided to replace `COMMIT_HASH` with `BUILD_ID` as part the identifier of the container to cope with rebuilding, suffixed by an index (`-n`) to cope with parallel running. Reason is that if a job is interrupted, we have to clean up all the containers started by that job. 2. Bug of verifications are fixed and tests are added, though I'm not very satisfied with the design now, any better design for verifications are welcome to discuss. 3. Will try to add another sample including this later 4. Verifications of services, topology, traces are added, metrics are in progress
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
