lujiajing1126 commented on a change in pull request #45: URL: https://github.com/apache/skywalking-banyandb/pull/45#discussion_r703962416
########## File path: api/proto/banyandb/stream/v2/write.proto ########## @@ -0,0 +1,50 @@ +// Licensed to Apache Software Foundation (ASF) under one or more contributor +// license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright +// ownership. Apache Software Foundation (ASF) licenses this file to you under +// the Apache License, Version 2.0 (the "License"); you may +// not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +syntax = "proto3"; + +option java_package = "org.apache.skywalking.banyandb.stream.v2"; +option go_package = "github.com/apache/skywalking-banyandb/api/proto/banyandb/stream/v2"; + +package banyandb.stream.v2; + +import "google/protobuf/timestamp.proto"; +import "banyandb/common/v2/common.proto"; +import "banyandb/model/v2/common.proto"; + +message ElementValue { + // element_id could be span_id of a Span or segment_id of a Segment in the context of stream + string element_id = 1; + // timestamp_nanoseconds is in the timeunit of nanoseconds. It represents + // 1) either the start time of a Span/Segment, + // 2) or the timestamp of a log + google.protobuf.Timestamp timestamp = 2; + message TagFamily { Review comment: The name of `TagFamily` is duplicated here as we've already defined a `TagFamily` in `schema.proto`. Shall we use `TagValueFamily` here? ########## File path: banyand/metadata/schema/data/index_rule_binding.json ########## @@ -0,0 +1,25 @@ +{ Review comment: Now we are using `json` instead of `prototext` files? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
