wu-sheng commented on a change in pull request #27:
URL: https://github.com/apache/skywalking-java/pull/27#discussion_r711735928
##########
File path:
apm-protocol/apm-network/src/main/java/org/apache/skywalking/apm/network/trace/component/ComponentsDefine.java
##########
@@ -207,4 +207,6 @@
public static final OfficialComponent GUAVA_CACHE = new
OfficialComponent(114, "GuavaCache");
+ public static final OfficialComponent DRUID = new OfficialComponent(115,
"druid");
Review comment:
`druid` should be renamed as `AlibabaDruid`. As I checked, Druid is an
Apache software foundation trademark, see https://druid.apache.org/.
I treat this as potential trademark conflict, we at least should keep it
clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
