kezhenxu94 commented on a change in pull request #7766: URL: https://github.com/apache/skywalking/pull/7766#discussion_r715358912
########## File path: oap-server/server-storage-plugin/storage-iotdb-plugin/pom.xml ########## @@ -0,0 +1,37 @@ +<?xml version="1.0" encoding="UTF-8"?> +<project xmlns="http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + <parent> + <artifactId>server-storage-plugin</artifactId> + <groupId>org.apache.skywalking</groupId> + <version>8.8.0-SNAPSHOT</version> + </parent> + <modelVersion>4.0.0</modelVersion> + + <artifactId>storage-iotdb-plugin</artifactId> + <packaging>jar</packaging> + + <properties> + <maven.compiler.source>11</maven.compiler.source> + <maven.compiler.target>11</maven.compiler.target> + </properties> + + <dependencies> + <dependency> + <groupId>org.apache.skywalking</groupId> + <artifactId>server-core</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> + <groupId>org.apache.skywalking</groupId> + <artifactId>library-client</artifactId> + <version>${project.version}</version> + </dependency> + <dependency> Review comment: We should be using IoTDB client SDK but `tomcat-embed-core` seems to be a server side dependency, can you confirm we can exclude it? I don't want to include unnecessary dependencies which might bring CVE in the future -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
