hanahmily commented on a change in pull request #33:
URL: https://github.com/apache/skywalking-swck/pull/33#discussion_r715624082
##########
File path: config/operator/configmap/configmap.yaml
##########
@@ -45,17 +45,16 @@ data:
# The service name in UI
Review comment:
As we disscussed, `agent.config` should be like:
```yaml
# The service name in UI
agent.service_name=${SW_AGENT_NAME:Your_ApplicationName}
# Backend service addresses.
collector.backend_service=${SW_AGENT_COLLECTOR_BACKEND_SERVICES:127.0.0.1:11800}
# Please refer to
https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/configurations/#table-of-agent-configuration-properties
to get more details.
```
##########
File path: pkg/operator/manifests/injector/templates/annotations.yaml
##########
@@ -113,12 +113,6 @@ annotations:
useQuotes: nil
Review comment:
Like the configmap, we should verify the service name and collector
address at most.
##########
File path: docs/examples/java-agent-injector.md
##########
@@ -0,0 +1,333 @@
+## Java agent injector manual
+
+The java agent injector consists of three parts:
Review comment:
should be "support two methods to configure the agent"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
