mrproliu commented on a change in pull request #47:
URL:
https://github.com/apache/skywalking-infra-e2e/pull/47#discussion_r716563339
##########
File path: internal/components/setup/compose.go
##########
@@ -67,7 +68,17 @@ func ComposeSetup(e2eConfig *config.E2EConfig) error {
return fmt.Errorf("bind wait ports error: %v", err)
}
- execError := compose.WithCommand([]string{"up", "-d"}).Invoke()
+ // build command
+ cmd := make([]string, 0)
+ if e2eConfig.Setup.InitSystemEnvironment != "" {
+ profilePath :=
util.ResolveAbs(e2eConfig.Setup.InitSystemEnvironment)
+ cmd = append(cmd, "--env-file", profilePath)
+ util.ExportEnvVars(profilePath)
Review comment:
It's goods to let `setup.steps` or `verify.query` commands could be
using these environments too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
