wu-sheng commented on a change in pull request #2973: Support etcd configuration. URL: https://github.com/apache/skywalking/pull/2973#discussion_r299481846
########## File path: oap-server/server-configuration/configuration-etcd/src/main/java/org/apache/skywalking/oap/server/configuration/etcd/EtcdServerSettings.java ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.configuration.etcd; + +import lombok.Getter; +import lombok.Setter; +import lombok.ToString; +import org.apache.skywalking.oap.server.library.module.ModuleConfig; + +/** + * @author Alan Lau + */ +@ToString +@Getter +@Setter +public class EtcdServerSettings extends ModuleConfig { + + private String clusterName = "default"; + private String serverAddr; + private String group; + private int period = 5; Review comment: default is 5, unit? If unit=second, I think it is too short for timeout, try 30 for configuration center, because in most case, people don't treat performance and latency very seriously for it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
