sialais opened a new issue #7875:
URL: https://github.com/apache/skywalking/issues/7875


   ### Search before asking
   
   - [X] I had searched in the 
[issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no 
similar issues.
   
   
   ### Apache SkyWalking Component
   
   Java Agent (apache/skywalking-java)
   
   ### What happened
   
   we config trace ignore paths by 
"agent/config/pm-trace-ignore-plugin.config", but found paths ends by "/" are 
not ignored with "**".
   
   example configuration in pm-trace-ignore-plugin.config:
   ```text
   trace.ignore_path=/v1/kv/config/**
   ```
   request path "/v1/kv/config/someurl/" is not ignored.
   
   ### What you expected to happen
   
   request path "/v1/kv/config/someurl/" (end with slash) should be ignored, as 
""/v1/kv/config/someurl"(not end with slash)
   
   ### How to reproduce
   
   just run agent with example config.
   
   ### Anything else
   
   Ant path match style should match paths end with slash. [Spring 
AntPathMatcher](https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/util/AntPathMatcher.html).
   
   In skywalking-java-agent, there are unit tests for this, but they do not act 
in the way "ant path matcher" describes.
   
   - 
https://github.com/apache/skywalking-java/blob/v8.7.0/apm-sniffer/optional-plugins/trace-ignore-plugin/src/test/java/org/apache/skywalking/apm/plugin/trace/ignore/TracePathMatcherTest.java#L62
   - 
https://github.com/apache/skywalking-java/blob/v8.7.0/apm-sniffer/optional-plugins/trace-ignore-plugin/src/test/java/org/apache/skywalking/apm/plugin/trace/ignore/TracePathMatcherTest.java#L97
   
   they should return true, as described in [skywalking 
doc](https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/agent-optional-plugins/trace-ignore-plugin/#how-to-configure)
 
   
   > The current matching rules follow Ant Path match style , like /path/*, 
/path/**, /path/?.
   
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to