wu-sheng commented on a change in pull request #7888:
URL: https://github.com/apache/skywalking/pull/7888#discussion_r725552485
##########
File path: oap-server/server-starter/src/main/resources/component-libraries.yml
##########
@@ -637,3 +640,4 @@ Component-Server-Mappings:
Psychopg: PostgreSQL
GoMysql: Mysql
ClickHouse-jdbc-driver: ClickHouse
+ Apache-kylin-jdbc-driver: Apache-kylin
Review comment:
And K should be upper case?
##########
File path: oap-server/server-starter/src/main/resources/component-libraries.yml
##########
@@ -637,3 +640,4 @@ Component-Server-Mappings:
Psychopg: PostgreSQL
GoMysql: Mysql
ClickHouse-jdbc-driver: ClickHouse
+ Apache-kylin-jdbc-driver: Apache-kylin
Review comment:
Where is the definition of apache-kylin? I think you missed this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
