wu-sheng commented on a change in pull request #74:
URL:
https://github.com/apache/skywalking-satellite/pull/74#discussion_r727666644
##########
File path: docs/en/setup/plugins/receiver_grpc-envoyals-v3-receiver.md
##########
@@ -0,0 +1,11 @@
+# Receiver/grpc-envoyals-v3-receiver
Review comment:
Why no `-` between `envoy` and `als`?
##########
File path: plugins/receiver/grpc/envoyalsv2/als_service.go
##########
@@ -0,0 +1,63 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package envoyalsv2
+
+import (
+ "io"
+ "time"
+
+ v2 "skywalking.apache.org/repo/goapi/proto/envoy/service/accesslog/v2"
+ v1 "skywalking.apache.org/repo/goapi/satellite/data/v1"
+)
+
+const eventName = "grpc-envoy-als-v2-event"
+
+type AlsService struct {
+ receiveChannel chan *v1.SniffData
+ v2.UnimplementedAccessLogServiceServer
+}
+
+func (m *AlsService) StreamAccessLogs(stream
v2.AccessLogService_StreamAccessLogsServer) error {
+ var identifier *v2.StreamAccessLogsMessage_Identifier
+ for {
+ item, err := stream.Recv()
+ if err == io.EOF {
+ return
stream.SendAndClose(&v2.StreamAccessLogsResponse{})
+ }
+ if err != nil {
+ return err
+ }
+ // only first item has identifier property
+ // need correlate information to each item
+ if item.Identifier != nil {
+ identifier = item.Identifier
+ }
+ item.Identifier = identifier
Review comment:
Should we consider to package one stream package(all elements) as one
message event?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
