wu-sheng commented on a change in pull request #8037:
URL: https://github.com/apache/skywalking/pull/8037#discussion_r738946111
##########
File path: docs/en/guides/README.md
##########
@@ -50,16 +50,15 @@ Since version 6.3.0, we have introduced more automatic
tests to perform software
> End-to-end testing is a methodology used to test whether the flow of an
> application is performing as designed from start to finish.
The purpose of carrying out end-to-end tests is to identify system
dependencies and to ensure that the right information is passed between various
system components and systems.
-The E2E test involves some/all of the OAP server, storage, coordinator,
webapp, and the instrumented services, all of which are orchestrated by
`docker-compose`. Besides, there is a test controller (JUnit test) running
outside of the container that sends traffic to the instrumented service,
-and then verifies the corresponding results after those requests have been
made through GraphQL API of the SkyWalking Web App.
+The E2E test involves some/all of the OAP server, storage, coordinator,
webapp, and the instrumented services, all of which are orchestrated by
`docker-compose`.
Review comment:
```suggestion
The E2E test involves some/all of the OAP server, storage, coordinator,
webapp, and the instrumented services, all of which are orchestrated by
`docker-compose` or `KinD`.
```
##########
File path: CHANGES.md
##########
@@ -7,27 +7,7 @@ Release Notes.
#### Project
-* Replace e2e cases to e2e-v2:
- - Simple: JDK, Auth, SSL, mTLS
- - Lua Nginx
- - SelfObservability
- - Gateway
- - Meter
- - Nodejs
- - PHP
- - VM: Prometheus Node Exporter, Zabbix
- - go2sky
- - log
- - Python
- - Storage
- - Cluster
- - Event
- - Profile
- - Kafka: Base, Meter, Log, Profile
- - Client-JS
- - Istio: ALS, Metrics
- - TTL
- - Alarm
+* E2e immigrate to e2e-v2.
Review comment:
```suggestion
* E2E tests immigrate to e2e-v2.
```
##########
File path: docs/en/guides/README.md
##########
@@ -71,17 +70,15 @@ To make the orchestration process easier, we're using a
[docker-compose](https:/
Follow these steps:
1. Decide what (and how many) containers will be needed. For example, for
cluster testing, you'll need > 2 OAP nodes, coordinators (e.g. zookeeper),
storage (e.g. ElasticSearch), and instrumented services;
1. Define the containers in `docker-compose.yml`, and carefully specify the
dependencies, starting orders, and most importantly, link them together, e.g.
set the correct OAP address on the agent end, and set the correct coordinator
address in OAP, etc.
-1. Write (or hopefully reuse) the test codes to verify that the results are
correct.
-
-As for the final step, we have a user-friendly framework to help you get
started more quickly. This framework provides the annotation
`@DockerCompose("docker-compose.yml")` to load/parse and start up all the
containers in the proper order.
-`@ContainerHost`/`@ContainerPort` obtains the real host/port of the container.
`@ContainerHostAndPort` obtains both. `@DockerContainer` obtains the running
container.
-
-- Write test controller
+1. Define the e2e case
[config](https://skywalking.apache.org/docs/skywalking-infra-e2e/latest/en/setup/configuration-file/)
in `e2e.yaml`.
+1. Write the expected data(yml) for verify.
-Put it simply, test controllers are tests that can be bound to the maven
`integration-test/verify` phase.
-They send **design** requests to the instrumented services, and anticipate
corresponding traces/metrics/metadata from the SkyWalking webapp GraphQL API.
+- [Run e2e
test](https://skywalking.apache.org/docs/skywalking-infra-e2e/latest/en/setup/run-e2e-tests/)
-In the test framework, we provide a `TrafficController` that periodically
sends traffic data to the instrumented services. You can simply enable it by
providing a url and traffic data. Refer to
[this](../../../test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/base/TrafficController.java).
+All e2e cases should under `skywalking/test/e2e-v2/cases`, and under
`skywalking/` execute e2e run command eg.
Review comment:
```suggestion
All e2e cases should under `skywalking/test/e2e-v2/cases`. You could execute
e2e run command in `skywalking/` e.g.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
