wu-sheng commented on a change in pull request #56:
URL:
https://github.com/apache/skywalking-data-collect-protocol/pull/56#discussion_r748698435
##########
File path: language-agent/Meter.proto
##########
@@ -30,6 +30,10 @@ service MeterReportService {
// Meter data is reported in a certain period. The agent/SDK should report
all collected metrics in this period through one stream.
rpc collect (stream MeterData) returns (Commands) {
}
+
+ // It is recommended to keep the stream alive for performance
considerations
Review comment:
I think this is not a good command for a service.
```suggestion
// Reporting meter data in bulk mode as MeterDataCollection.
// By using this, each one in the stream would be treated as a complete
input for MAL engine.
// Comparing to `collect (stream MeterData)`, one stream is an input
data set.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
