wu-sheng commented on a change in pull request #8165: URL: https://github.com/apache/skywalking/pull/8165#discussion_r753815353
########## File path: test/e2e-v2/java-test-service/e2e-mock-sender/src/main/java/org/apache/skywalking/e2e/controller/MeterMetricSenderController.java ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.e2e.controller; + +import io.grpc.ManagedChannel; +import io.grpc.internal.DnsNameResolverProvider; +import io.grpc.netty.NettyChannelBuilder; +import io.grpc.stub.StreamObserver; +import java.util.concurrent.CountDownLatch; +import org.apache.skywalking.apm.network.common.v3.Commands; +import org.apache.skywalking.apm.network.language.agent.v3.MeterData; +import org.apache.skywalking.apm.network.language.agent.v3.MeterDataCollection; +import org.apache.skywalking.apm.network.language.agent.v3.MeterReportServiceGrpc; +import org.apache.skywalking.apm.network.language.agent.v3.MeterSingleValue; +import org.apache.skywalking.e2e.E2EConfiguration; +import org.springframework.web.bind.annotation.PostMapping; +import org.springframework.web.bind.annotation.RestController; + +@RestController +public class MeterMetricSenderController { + private static final int MAX_INBOUND_MESSAGE_SIZE = 1024 * 1024 * 50; + private static final boolean SUCCESS = true; + private final MeterReportServiceGrpc.MeterReportServiceStub grpcStub; + + public MeterMetricSenderController(final E2EConfiguration configuration) { + final ManagedChannel channel = NettyChannelBuilder.forAddress( + configuration.getOapHost(), Integer.parseInt(configuration.getOapGrpcPort())) + .nameResolverFactory(new DnsNameResolverProvider()) + .maxInboundMessageSize(MAX_INBOUND_MESSAGE_SIZE) + .usePlaintext() + .build(); + + grpcStub = MeterReportServiceGrpc.newStub(channel); + } + + @PostMapping("/sendBatchMetrics") + public String sendMetrics4TTL() throws Exception { Review comment: I think this name is copied from other case? ########## File path: oap-server/server-receiver-plugin/skywalking-meter-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/meter/provider/handler/BatchMeterServiceHandler.java ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.receiver.meter.provider.handler; + +import io.grpc.stub.StreamObserver; +import lombok.extern.slf4j.Slf4j; +import org.apache.skywalking.apm.network.common.v3.Commands; +import org.apache.skywalking.apm.network.language.agent.v3.MeterData; +import org.apache.skywalking.apm.network.language.agent.v3.MeterDataCollection; +import org.apache.skywalking.apm.network.language.agent.v3.MeterReportServiceGrpc; +import org.apache.skywalking.oap.server.analyzer.provider.meter.process.IMeterProcessService; +import org.apache.skywalking.oap.server.analyzer.provider.meter.process.MeterProcessor; +import org.apache.skywalking.oap.server.library.module.ModuleManager; +import org.apache.skywalking.oap.server.library.server.grpc.GRPCHandler; +import org.apache.skywalking.oap.server.telemetry.TelemetryModule; +import org.apache.skywalking.oap.server.telemetry.api.CounterMetrics; +import org.apache.skywalking.oap.server.telemetry.api.HistogramMetrics; +import org.apache.skywalking.oap.server.telemetry.api.MetricsCreator; +import org.apache.skywalking.oap.server.telemetry.api.MetricsTag; + +/** + * Meter protocol receiver, collect and process the meters. + */ +@Slf4j +public class BatchMeterServiceHandler extends MeterReportServiceGrpc.MeterReportServiceImplBase implements GRPCHandler { + + private final IMeterProcessService processService; + private final HistogramMetrics histogram; + private final CounterMetrics errorCounter; + + public BatchMeterServiceHandler(ModuleManager manager, IMeterProcessService processService) { + this.processService = processService; + MetricsCreator metricsCreator = manager.find(TelemetryModule.NAME) + .provider() + .getService(MetricsCreator.class); + histogram = metricsCreator.createHistogramMetric( + "meter_in_latency", "The process latency of meter", + new MetricsTag.Keys("protocol"), new MetricsTag.Values("grpc") + ); + errorCounter = metricsCreator.createCounter("meter_analysis_error_count", "The error number of meter analysis", + new MetricsTag.Keys("protocol"), + new MetricsTag.Values("grpc") + ); + } + + @Override + public StreamObserver<MeterDataCollection> collectBatch(StreamObserver<Commands> responseObserver) { + return new StreamObserver<MeterDataCollection>() { + @Override + public void onNext(MeterDataCollection meterDataCollection) { + final MeterProcessor processor = processService.createProcessor(); Review comment: I think this should not be created inside `onNext`. Take a close look at `MeterServiceHandler`. It is created once for a streaming only. ########## File path: test/e2e-v2/java-test-service/e2e-mock-sender/src/main/java/org/apache/skywalking/e2e/controller/MeterMetricSenderController.java ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.e2e.controller; + +import io.grpc.ManagedChannel; +import io.grpc.internal.DnsNameResolverProvider; +import io.grpc.netty.NettyChannelBuilder; +import io.grpc.stub.StreamObserver; +import java.util.concurrent.CountDownLatch; +import org.apache.skywalking.apm.network.common.v3.Commands; +import org.apache.skywalking.apm.network.language.agent.v3.MeterData; +import org.apache.skywalking.apm.network.language.agent.v3.MeterDataCollection; +import org.apache.skywalking.apm.network.language.agent.v3.MeterReportServiceGrpc; +import org.apache.skywalking.apm.network.language.agent.v3.MeterSingleValue; +import org.apache.skywalking.e2e.E2EConfiguration; +import org.springframework.web.bind.annotation.PostMapping; +import org.springframework.web.bind.annotation.RestController; + +@RestController +public class MeterMetricSenderController { + private static final int MAX_INBOUND_MESSAGE_SIZE = 1024 * 1024 * 50; + private static final boolean SUCCESS = true; Review comment: ```suggestion ``` I think you don't need these two. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
