wu-sheng commented on a change in pull request #86:
URL:
https://github.com/apache/skywalking-satellite/pull/86#discussion_r754409942
##########
File path: configs/satellite_config.yaml
##########
@@ -37,8 +37,55 @@ telemetry:
sharing:
clients:
- plugin_name: "grpc-client"
+ # The gRPC server address finder type
+ finder_type: ${SATELLITE_GRPC_CLIENT_FINDER:static}
Review comment:
It is better to list all options here.
##########
File path: docs/en/setup/plugins/client_grpc-client.md
##########
@@ -30,6 +45,7 @@ check_period: 5
## Configuration
|Name|Type|Description|
|----|----|-----------|
+| finder_type | string | The gRPC server address finder type |
Review comment:
Please describe how to activate different finders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
