tedli commented on a change in pull request #73: URL: https://github.com/apache/skywalking-java/pull/73#discussion_r754862702
########## File path: apm-sniffer/apm-sdk-plugin/dubbo-3-conflict-patch/src/main/java/org/apache/skywalking/apm/plugin/asf/dubbo3/patch/WrapperInstrumentation.java ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.skywalking.apm.plugin.asf.dubbo3.patch; + +import net.bytebuddy.description.method.MethodDescription; +import net.bytebuddy.matcher.ElementMatcher; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.StaticMethodsInterceptPoint; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.ClassStaticMethodsEnhancePluginDefine; +import org.apache.skywalking.apm.agent.core.plugin.match.ClassMatch; + +import static net.bytebuddy.matcher.ElementMatchers.named; +import static org.apache.skywalking.apm.agent.core.plugin.match.NameMatch.byName; + +/** + * The dubbo conflict plugin resolver the problem about the wrapper class generated by Dubbo core cannot be compiled + * successfully. As we known, The wrapper class traverses all the methods. In usual, it works unless this class has been + * enhanced by Skywalking. The javasist cannot found the `EnhanceInstance` method when generate. + * <p> + * The plugin excludes {@link org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance} methods + * to ensure the correct compilation of the code. + */ +public class WrapperInstrumentation extends ClassStaticMethodsEnhancePluginDefine { + @Override + public StaticMethodsInterceptPoint[] getStaticMethodsInterceptPoints() { + return new StaticMethodsInterceptPoint[] { + new StaticMethodsInterceptPoint() { + @Override + public ElementMatcher<MethodDescription> getMethodsMatcher() { + return named("makeWrapper"); + } + + @Override + public String getMethodsInterceptor() { + return "org.apache.skywalking.apm.plugin.asf.dubbo3.patch.MakeWrapperInterceptor"; + } + + @Override + public boolean isOverrideArgs() { + return false; + } + } + }; + } + + @Override + protected ClassMatch enhanceClass() { + return byName("org.apache.dubbo.common.bytecode.Wrapper"); Review comment: It because, for classes and methods expose to user side (rpc level) is compatible with v2, but the internal dosen't. For example we can't rely on `RpcContext.getContext()` with v3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
