kezhenxu94 commented on a change in pull request #83:
URL:
https://github.com/apache/skywalking-kubernetes/pull/83#discussion_r755745816
##########
File path: .github/workflows/e2e.ci.yaml
##########
@@ -28,8 +28,10 @@ env:
SKIP_TEST: true
ISTIO_VERSION: 1.7.1
TAG: ${{ github.sha }}
- SCRIPTS_DIR: main/test/e2e-mesh/e2e-istio/scripts
- SW_OAP_BASE_IMAGE: openjdk:8-jre-alpine
+ OAP_TAG: ${{ github.sha }}
Review comment:
> I mean this is `skywalking-kubernetes` repo, why this sha code could
be used for OAP_TAG?
It's used as the tag when building a new OAP docker.
Though I ask to replace with a pre-built Docker image
https://github.com/apache/skywalking-kubernetes/pull/83#discussion_r755736325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
