toffentoffen opened a new pull request #8186: URL: https://github.com/apache/skywalking/pull/8186
Upgrade to the latest grpc-java 1.42.1 which is only compatible and [tested against](https://github.com/grpc/grpc-java/pull/8551#discussion_r714182190) 3.17.2, but we can assume that 3.17.3 (which has osx-aarch_64 compatible maven artifacts) is save to use. We could have also upgrade to the latest grpc-java 1.42.1 and latest protoc 3.19.1, but it can not be directly done, it needs to tweak the grpcs-java internal dependencies. So we choose the safest option and discarded this option because of the following reasons: - Protoc 3.19.1 generates code that relies on methods not available in protobuf-java 3.17.2 ([βissueβ](https://github.com/protocolbuffers/protobuf/issues/9236#issue-1059594027)) (which java-grpc relies on). So we need to tell grpc-java via dependency management to use 3.19.1 instead of 3.17.2. <!-- β οΈ Please make sure to read this template first, pull requests that don't accord with this template maybe closed without notice. Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>. Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]` --> <!-- ==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ==== ### Fix <bug description or the bug issue number or bug issue link> - [ ] Add a unit test to verify that the fix works. - [ ] Explain briefly why the bug exists and how to fix it. ==== π Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist π ==== --> <!-- ==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ==== ### Improve the performance of <class or module or ...> - [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java) - [ ] The benchmark result. ```text <Paste the benchmark results here> ``` - [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here> ==== π Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist π ==== --> <!-- ==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ==== ### <Feature description> - [ ] If this is non-trivial feature, paste the links/URLs to the design doc. - [ ] Update the documentation to include this new feature. - [ ] Tests(including UT, IT, E2E) are added to verify the new feature. - [ ] If it's UI related, attach the screenshots below. ==== π Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist π ==== --> - [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #8184. - [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
