hanahmily commented on a change in pull request #52:
URL: https://github.com/apache/skywalking-swck/pull/52#discussion_r765893756
##########
File path: operator/main.go
##########
@@ -164,12 +163,12 @@ func main() {
setupLog.Info("/mutate-v1-pod webhook is registered")
}
- if err := mgr.AddHealthzCheck("healthz", healthz.Ping); err != nil {
- setupLog.Error(err, "unable to set up health check")
+ if err := mgr.AddHealthzCheck("webhook",
mgr.GetWebhookServer().StartedChecker()); err != nil {
Review comment:
1. you could not change the checker's name which is referred to at
https://github.com/apache/skywalking-swck/blob/master/operator/config/manager/manager.yaml#L58
2. The webhooks are active when `ENABLE_WEBHOOKS` is true. Based on that,
you should move the webhook checkers to the above block with other webhooks,
and enable `healthz.Ping` when `ENABLE_WEBHOOKS` is false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
