kezhenxu94 commented on a change in pull request #63:
URL:
https://github.com/apache/skywalking-query-protocol/pull/63#discussion_r766286851
##########
File path: topology.graphqls
##########
@@ -58,12 +63,11 @@ type ServiceInstanceNode {
serviceId: ID!
# The literal name of the #serviceId.
serviceName: String!
- # The type name may be
- # 1. The service provider/middleware tech, such as: Tomcat, SpringMVC
- # 2. Conjectural Service, e.g. MySQL, Redis, Kafka
+
+ # Deprecated since 9.0.0. Instance is an executable unit of service, it
doesn't have its own type.
type: String
- # It is a conjecture node or real node, to represent an instance.
- isReal: Boolean!
+ # Deprecated since 9.0.0. Don't need to use this anymore
+ isReal: Boolean
Review comment:
> Could you share which specific one do you have concern?
Not a critical concern but looking this kind of changes reminded me that if
the new backend returns `null` for this field, the previous consumer of this
protocol will break, but if the backend keeps returning non-null value then
adding the deprecate message should be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
