wu-sheng commented on a change in pull request #95:
URL:
https://github.com/apache/skywalking-satellite/pull/95#discussion_r771143228
##########
File path: docs/en/setup/plugins/forwarder_nativemeter-grpc-forwarder.md
##########
@@ -2,8 +2,15 @@
## Description
This is a synchronization meter grpc forwarder with the SkyWalking meter
protocol.
## DefaultConfig
-```yaml```
+```yaml
+# The upstream LRU Cache max size
+upstream_lru_cache_size: 5000
+# The upstream LRU Cache time(second) on each service instance
+upstream_lru_cache_ttl: 180
+```
## Configuration
|Name|Type|Description|
|----|----|-----------|
+| upstream_lru_cache_size | int | The upstream LRU Cache max size |
+| upstream_lru_cache_ttl | int | The upstream LRU Cache time(second) on each
service instance |
Review comment:
I am reading again, feel like these two names are misleading. I think we
are not just caching `upstream`, the real data in the cache is the
`routine_rule` of meter data.
```suggestion
| routine_rule_lru_cache_size | int | The LRU policy cache size for hosting
routine rules of service instance. |
| routine_rule_lru_cache_ttl | int | The TTL of the LRU cache size for
hosting routine rules of service instance. |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
