wu-sheng commented on issue #3017: fix deleteIndex repeat append namespace URL: https://github.com/apache/skywalking/pull/3017#issuecomment-509681163 @peng-yongsheng @dmsolr Then this is my suggestion 1. Change `public boolean deleteIndex(String indexName) throws IOException` to `public boolean deleteByModelName(String noTimeSeriesMode) throws IOException`, also add comment to describe the argument. 1. Add `public boolean deleteByIndexName(String indexName) throws IOException`, do delete OP w/o format. > Now, I only think ElasticSearchTimeSeriesIndex redundant Yes. But basically, we are just talking about naming style. For `getIndex`, if you need it in ITTest, add a new method in ITTest.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
