peng-yongsheng commented on a change in pull request #3017: fix deleteIndex
repeat append namespace
URL: https://github.com/apache/skywalking/pull/3017#discussion_r302131872
##########
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/elasticsearch/ElasticSearchClient.java
##########
@@ -57,13 +58,15 @@
public static final String TYPE = "type";
private final String clusterNodes;
private final String namespace;
+ private final String namespacePrefix;
private final String user;
private final String password;
private RestHighLevelClient client;
public ElasticSearchClient(String clusterNodes, String namespace, String
user, String password) {
this.clusterNodes = clusterNodes;
this.namespace = namespace;
+ this.namespacePrefix = namespace + "_";
Review comment:
I think this.namespacePrefix attribute is no value because we have a common
method named formatIndexName.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
