xu1009 commented on pull request #95: URL: https://github.com/apache/skywalking-java/pull/95#issuecomment-1019760276
> > the way is to make new thread type add is simple, just get ThreadPoolExecutor instacne and register it, and then, the main metric can be send to the backend > > You just need to create the metric, register it and hold it in the pool object. What we recommended is making your PR easier. but, this way, every new plugin needs to create metric, i think eh > @xu1009 Please take a deep like at our comments. Most things you did have been provided at the core level. Because most of this registration mechanism is a common requirement. in this way, every new plugin needs to create metirc, i want to extract these common things to core -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
