wu-sheng commented on a change in pull request #3048: "One trace segment has
been abandoned, cause by buffer is full" bug fix.
URL: https://github.com/apache/skywalking/pull/3048#discussion_r302429931
##########
File path:
oap-server/server-library/library-client/src/main/java/org/apache/skywalking/oap/server/library/client/elasticsearch/ElasticSearchClient.java
##########
@@ -210,7 +210,8 @@ public void afterBulk(long executionId, BulkRequest
request, Throwable failure)
return BulkProcessor.builder(client::bulkAsync, listener)
.setBulkActions(bulkActions)
.setBulkSize(new ByteSizeValue(bulkSize, ByteSizeUnit.MB))
- .setFlushInterval(TimeValue.timeValueSeconds(flushInterval))
+ // modified by zhaoze, if set auto flush, there will cause
deadlock with bulk commit.
Review comment:
Make comment without yout name, just why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
