[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #66: add lint pre-commit hook

[GitBox]

kezhenxu94 commented on pull request #66:
URL: https://github.com/apache/skywalking-nodejs/pull/66#issuecomment-1023852569


   > @kezhenxu94 
   > 
   > I commited a PR here,But there are still three possible problems,Do you 
need me to handle this?
   > 
   > 1. When I install using npm install(before I add the dependencies ), it 
shows
   > 
   > <img width="288" alt="image" 
src="https://user-images.githubusercontent.com/70385062/151481433-31457351-be0d-4862-b736-30c9c00734f3.png";>
   > 
   
   It's nice if you'd like to upgrade the 2 modules, but please do it in 
another PR, it's also fine if you don't want. 
   
   > 
   > 2. has been deprecated,Do you need to switch to eslint
   > 
   > <img width="941" alt="image" 
src="https://user-images.githubusercontent.com/70385062/151481609-16e703f4-7a81-422b-af58-656dcdf806f1.png";>
   > 
   
   Yes. I know tslint was deprecated. I appreciate if you can try to replace 
with eslint. 😃
   
   > 
   > 3. The current tslint configuration header is not valid, because no match 
field check is configured
   > 
   > <img width="788" alt="image" 
src="https://user-images.githubusercontent.com/70385062/151481736-d5369786-24d5-41c3-a59c-89ca0877113f.png";>
   > 
   
   The configuration worked for me in my environment, if you switch to eslint 
you can migrate the configurations also, I can test in my environment 
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org