mrproliu commented on a change in pull request #62: URL: https://github.com/apache/skywalking-data-collect-protocol/pull/62#discussion_r809657667
########## File path: rover/Process.proto ########## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +syntax = "proto3"; + +package skywalking.v3; + +option java_multiple_files = true; +option java_package = "org.apache.skywalking.apm.network.rover.process.v3"; +option go_package = "skywalking.apache.org/repo/goapi/collect/rover/process/v3"; + +import "common/Common.proto"; +import "rover/Common.proto"; + +// Define the Rover detected processes and report them. +service ProcessService { + // Report discovered process in Rover + rpc reportProcess (stream ProcessProperties) returns (RoverProbeDownstream) { + } + + // Keep the process alive in the backend. + rpc keepAlive (ProcessPingPkg) returns (RoverProbeDownstream) { + } +} + +message ProcessProperties { + // [required] Detect process mode + ProcessOwner owner = 1; + // [required] Host Process metadata + ProcessMetadata metadata = 2; + // [required] Process related function metadata + ProcessFeatures features = 3; + // [optional] Mapping process with other instance + // required when the process have agent/sdk installed + MappedInstance mappedInstance = 4; Review comment: I haven't added the SDK/Agent upload process protocol yet, but It needs to be confirmed on the Rover side, Only the rover side knows which process is mapped to the instance(because in the container case, the SDK/agent don't know the root namespace pid), so it should be determined in the Rover side, OAP side only provides the query and save service. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
