wu-sheng commented on a change in pull request #8564:
URL: https://github.com/apache/skywalking/pull/8564#discussion_r810630146
##########
File path:
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/base/StorageEsInstaller.java
##########
@@ -215,9 +215,9 @@ protected Mappings createMapping(Model model) {
properties.put(matchCName, matchColumn);
} else {
Map<String, Object> column = new HashMap<>();
- column.put(
- "type",
columnTypeEsMapping.transform(columnDefine.getType(),
columnDefine.getGenericType()));
- if (columnDefine.isStorageOnly()) {
+ column.put("type", type);
+ // no index parameter is allowed for binary type, since ES 8.0
Review comment:
Curiously, What binary fields are we setting `parameter`? And which
parameters did we set?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
