[GitHub] [skywalking] zhaoyuguang opened a new issue #3055: ContextManager.activeSpan() API usage error

Thu, 11 Jul 2019 20:08:31 -0700 

zhaoyuguang opened a new issue #3055: ContextManager.activeSpan() API usage 
error
URL: https://github.com/apache/skywalking/issues/3055
 
 
   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [x] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - 
   Look the code. such as:
   
![image](https://user-images.githubusercontent.com/10150229/61099499-1d4a4600-a495-11e9-9773-f417d6621d44.png)
   
![image](https://user-images.githubusercontent.com/10150229/61099508-29360800-a495-11e9-9f47-d8416577fc24.png)
   The code uses `ContextManager.activeSpan()` to determine if there is an 
active span in the current thread, which will cause NPE. The correct approach 
should be `ContextManager.isActive()` 
   I am right?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to