wu-sheng commented on a change in pull request #8617:
URL: https://github.com/apache/skywalking/pull/8617#discussion_r818403757
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/IDManager.java
##########
@@ -252,6 +255,21 @@ public static EndpointRelationDefine
analysisRelationId(String entityId) {
}
}
+ /**
+ * Process ID related functions.
+ */
+ public static class ProcessID {
+ /**
+ * @param instanceId built by {@link ServiceInstanceID#buildId(String,
String)}
+ * @param name process name
+ * @return process id
+ */
+ public static String buildId(String instanceId, String name) {
+ return
Hashing.sha256().newHasher().putString(String.format("%s_%s",
Review comment:
Yes, we need to keep the length fixed. The instance ID is closing to 512
which is the limitation for ElasticSearch/OpenSearch. But process belongs to an
instance, traditional base64 is not going to work well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
