qxo commented on issue #3065: Propose a API change : AbstractTracerContext#asyncStop and AsyncSpan#asyncFinish return boolean URL: https://github.com/apache/skywalking/pull/3065#issuecomment-511087090 @wu-sheng 1. just one span 2. span.prepareForAsync() then span.asyncFinish() will not finished the span async code not work as the [async-span-apis doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Java-Plugin-Development-Guide.md#async-span-apis) 3. sorrry for my poor english 我还是用中文表述： 虽然之前给出的API用例是不正确，但这个API的改除了插件要重新才能使用编译外没其他影响 可能是API使用不当，也可能是API内部实施逻辑有欠缺，今天我再验证一下 没找到对应的API的使用样例，有的话麻烦提供一下：） Question: 1. maybe just one span or maybe not, how to code the plugin on the last code ? should I use span.prepareForAsync() then span.asyncFinish() ? 2. should [asyncStop]( https://github.com/apache/skywalking/blob/535878054313d94e00f81c6a647bac2f92559207/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/TracingContext.java#L426) the pop logic same as [stopSpan](https://github.com/apache/skywalking/blob/535878054313d94e00f81c6a647bac2f92559207/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/TracingContext.java#L390)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
