wu-sheng commented on a change in pull request #8680: URL: https://github.com/apache/skywalking/pull/8680#discussion_r826685214
########## File path: oap-server/server-receiver-plugin/zipkin-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/zipkin/handler/ZipkinSpanHTTPHandler.java ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.receiver.zipkin.handler; + +import com.linecorp.armeria.common.HttpData; +import com.linecorp.armeria.common.HttpRequest; +import com.linecorp.armeria.common.HttpResponse; +import com.linecorp.armeria.common.HttpStatus; +import com.linecorp.armeria.server.ServiceRequestContext; +import com.linecorp.armeria.server.annotation.ConsumesJson; +import com.linecorp.armeria.server.annotation.ConsumesProtobuf; +import com.linecorp.armeria.server.annotation.Post; +import java.util.List; +import lombok.extern.slf4j.Slf4j; +import org.apache.skywalking.oap.server.core.CoreModule; +import org.apache.skywalking.oap.server.core.config.NamingControl; +import org.apache.skywalking.oap.server.core.source.SourceReceiver; +import org.apache.skywalking.oap.server.library.module.ModuleManager; +import org.apache.skywalking.oap.server.receiver.zipkin.ZipkinReceiverConfig; +import org.apache.skywalking.oap.server.receiver.zipkin.trace.SpanForward; +import org.apache.skywalking.oap.server.telemetry.TelemetryModule; +import org.apache.skywalking.oap.server.telemetry.api.CounterMetrics; +import org.apache.skywalking.oap.server.telemetry.api.HistogramMetrics; +import org.apache.skywalking.oap.server.telemetry.api.MetricsCreator; +import org.apache.skywalking.oap.server.telemetry.api.MetricsTag; +import zipkin2.Span; +import zipkin2.codec.SpanBytesDecoder; + +import static java.util.Objects.nonNull; + +@Slf4j +public class ZipkinSpanHTTPHandler { + private final ZipkinReceiverConfig config; + private final SourceReceiver sourceReceiver; + private final NamingControl namingControl; + private final HistogramMetrics histogram; + private final CounterMetrics errorCounter; + + public ZipkinSpanHTTPHandler(ZipkinReceiverConfig config, ModuleManager manager) { + sourceReceiver = manager.find(CoreModule.NAME).provider().getService(SourceReceiver.class); + namingControl = manager.find(CoreModule.NAME).provider().getService(NamingControl.class); + this.config = config; + MetricsCreator metricsCreator = manager.find(TelemetryModule.NAME) + .provider() + .getService(MetricsCreator.class); + histogram = metricsCreator.createHistogramMetric( + "trace_in_latency", "The process latency of trace data", + new MetricsTag.Keys("protocol"), new MetricsTag.Values("zipkin") + ); + errorCounter = metricsCreator.createCounter( + "trace_analysis_error_count", "The error number of trace analysis", + new MetricsTag.Keys("protocol"), new MetricsTag.Values("zipkin") + ); + } + + @Post("/api/v2/spans") + public HttpResponse collectV2Spans(ServiceRequestContext ctx, HttpRequest req) { + return doCollectSpans(SpanBytesDecoder.JSON_V2, ctx, req); + } + + @Post("/api/v2/spans") + @ConsumesJson + public HttpResponse collectV2JsonSpans(ServiceRequestContext ctx, HttpRequest req) { + return doCollectSpans(SpanBytesDecoder.JSON_V2, ctx, req); + } + + @Post("/api/v2/spans") + @ConsumesProtobuf + public HttpResponse collectV2ProtobufSpans(ServiceRequestContext ctx, HttpRequest req) { + return doCollectSpans(SpanBytesDecoder.PROTO3, ctx, req); + } + + @Post("/api/v1/spans") + public HttpResponse collectV1Spans(ServiceRequestContext ctx, HttpRequest req) { + return doCollectSpans(SpanBytesDecoder.JSON_V1, ctx, req); + } + + @Post("/api/v1/spans") + @ConsumesJson + public HttpResponse collectV1JsonSpans(ServiceRequestContext ctx, HttpRequest req) { + return doCollectSpans(SpanBytesDecoder.JSON_V1, ctx, req); + } + + @Post("/api/v1/spans") + @ConsumesThrift Review comment: Could you point out the doc to explain this? I think `x-thrift` is just a decoding process in Zipkin. Why does this relate to HTTP server? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
