This is an automated email from the ASF dual-hosted git repository.
wusheng pushed a commit to branch add-sharding-attr
in repository https://gitbox.apache.org/repos/asf/skywalking.git
The following commit(s) were added to refs/heads/add-sharding-attr by this push:
new ba3b6c7 Update comment a little
ba3b6c7 is described below
commit ba3b6c73f2b0f5fe48c78a6d76d255e259ccc114
Author: Wu Sheng <[email protected]>
AuthorDate: Fri Mar 18 17:20:03 2022 +0800
Update comment a little
---
CHANGES.md | 4 ++--
.../apache/skywalking/oap/server/core/storage/annotation/Column.java | 5 +++--
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/CHANGES.md b/CHANGES.md
index 05c5d23..4fbb585 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -127,8 +127,8 @@ Release Notes.
```
Sharding key is used to group time series data per metric of one entity.
For example,
-ServiceA's traffic gauge, service call per minute, includes following
timestamp values, then it should be
-[ServiceA: 01-28 18:30 values-1, 01-28 18:31 values-2, 01-28 18:32 values-3,
01-28 18:32 values-4]
+ServiceA's traffic gauge, service call per minute, includes following
timestamp values, then it should be shard by service ID
+[ServiceA(encoded ID): 01-28 18:30 values-1, 01-28 18:31 values-2, 01-28 18:32
values-3, 01-28 18:32 values-4]
BanyanDB is the 1st storage implementation supporting this. It would make
continuous time series metrics stored closely and compressed better.
diff --git
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
index f310c75..0af5fc1 100644
---
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
+++
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
@@ -104,8 +104,9 @@ public @interface Column {
/**
* Sharding key is used to group time series data per metric of one entity.
* For example,
- * ServiceA's traffic gauge, service call per minute, includes following
timestamp values, then it should be
- * [ServiceA: 01-28 18:30 values-1, 01-28 18:31 values-2, 01-28 18:32
values-3, 01-28 18:32 values-4]
+ * ServiceA's traffic gauge, service call per minute, includes following
timestamp values, then it should be shard
+ * by service ID
+ * [ServiceA(encoded ID): 01-28 18:30 values-1, 01-28 18:31 values-2,
01-28 18:32 values-3, 01-28 18:32 values-4]
*
* BanyanDB is the 1st storage implementation supporting this. It would
make continuous time series metrics stored
* closely and compressed better.
