lujiajing1126 commented on a change in pull request #8705:
URL: https://github.com/apache/skywalking/pull/8705#discussion_r829865669
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
##########
@@ -102,6 +101,28 @@
*/
AnalyzerType analyzer() default AnalyzerType.OAP_ANALYZER;
+ /**
+ * Sharding key is used to group time series data per metric of one entity.
+ * For example,
+ * ServiceA's traffic gauge, service call per minute, includes following
timestamp values, then it should be shard
+ * by service ID
+ * [ServiceA(encoded ID): 01-28 18:30 values-1, 01-28 18:31 values-2,
01-28 18:32 values-3, 01-28 18:32 values-4]
+ *
+ * BanyanDB is the 1st storage implementation supporting this. It would
make continuous time series metrics stored
+ * closely and compressed better.
+ *
+ * 1. One entity at most has one sharding key
Review comment:
No. We support sharding with multiple keys now.
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
##########
@@ -102,6 +101,28 @@
*/
AnalyzerType analyzer() default AnalyzerType.OAP_ANALYZER;
+ /**
+ * Sharding key is used to group time series data per metric of one entity.
+ * For example,
+ * ServiceA's traffic gauge, service call per minute, includes following
timestamp values, then it should be shard
+ * by service ID
+ * [ServiceA(encoded ID): 01-28 18:30 values-1, 01-28 18:31 values-2,
01-28 18:32 values-3, 01-28 18:32 values-4]
+ *
+ * BanyanDB is the 1st storage implementation supporting this. It would
make continuous time series metrics stored
+ * closely and compressed better.
Review comment:
```suggestion
* closely and compressed better. Besides, it can significantly
alleviate high-cardinality issue for some indexed tags.
```
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
##########
@@ -102,6 +101,28 @@
*/
AnalyzerType analyzer() default AnalyzerType.OAP_ANALYZER;
+ /**
+ * Sharding key is used to group time series data per metric of one entity.
+ * For example,
+ * ServiceA's traffic gauge, service call per minute, includes following
timestamp values, then it should be shard
+ * by service ID
+ * [ServiceA(encoded ID): 01-28 18:30 values-1, 01-28 18:31 values-2,
01-28 18:32 values-3, 01-28 18:32 values-4]
Review comment:
```suggestion
* [ServiceA(encoded via hash function): 01-28 18:30 values-1, 01-28
18:31 values-2, 01-28 18:32 values-3, 01-28 18:32 values-4]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
