wu-sheng commented on a change in pull request #8703:
URL: https://github.com/apache/skywalking/pull/8703#discussion_r829703035
##########
File path: docs/en/setup/backend/configuration-vocabulary.md
##########
@@ -230,6 +230,7 @@ core|default|role|Option values:
`Mixed/Receiver/Aggregator`. **Receiver** mode
| - | - | sampleRate | Sampling rate for receiving trace. Precise to 1/10000.
10000 means sampling rate of 100% by default. | SW_RECEIVER_BROWSER_SAMPLE_RATE
| 10000 |
| query | graphql | - | GraphQL query implementation. | - |
| - | - | enableLogTestTool | Enable the log testing API to test the LAL.
**NOTE**: This API evaluates untrusted code on the OAP server. A malicious
script can do significant damage (steal keys and secrets, remove files and
directories, install malware, etc). As such, please enable this API only when
you completely trust your users. | SW_QUERY_GRAPHQL_ENABLE_LOG_TEST_TOOL |
false |
+| - | - | maxQueryComplexity | Maximum complexity allowed for the GraphQL
query that can be used to abort a query if the total number of data fields
queried exceeds the defined threshold. | SW_QUERY_MAX_QUERY_COMPLEXITY | 30 |
Review comment:
Let's make it 50 or 100. Today new dashboard could set up a complex page.
##########
File path: .github/workflows/skywalking.yaml
##########
@@ -18,17 +18,18 @@ name: CI
on:
pull_request:
- paths-ignore:
- - "*.md"
- - "*.txt"
- - "skywalking-ui"
- - ".asf.yaml"
- - ".dlc.yaml"
- - ".licenserc.yaml"
- - "docs/menu.yml"
- - ".github/workflows/codeql.yaml"
- - "dist-material/release-docs"
- - "*/component-libraries.yml"
+ paths:
Review comment:
What does this `paths-ignore` to `path` mean? The following patterns
should be CI irrelative?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
