This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
     new fed3df3  Fix comments. (#8708)
fed3df3 is described below

commit fed3df305ef2ba227cead177091c4a084e99aeef
Author: 吴晟 Wu Sheng <[email protected]>
AuthorDate: Sat Mar 19 09:38:15 2022 +0800

    Fix comments. (#8708)
---
 CHANGES.md                                                            | 4 ++--
 .../apache/skywalking/oap/server/core/storage/annotation/Column.java  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/CHANGES.md b/CHANGES.md
index 29e605b..460fdd0 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -125,8 +125,8 @@ Release Notes.
 * Add `Column.shardingKeyIdx` for column definition for BanyanDB.
 
 ```
-Sharding key is used to group time series data per metric of one entity in one 
place (same sharding or same 
-column for column-oriented database).
+Sharding key is used to group time series data per metric of one entity in one 
place (same sharding and/or same 
+row for column-oriented database).
 For example,
 ServiceA's traffic gauge, service call per minute, includes following 
timestamp values, then it should be sharded by service ID
 [ServiceA(encoded ID): 01-28 18:30 values-1, 01-28 18:31 values-2, 01-28 18:32 
values-3, 01-28 18:32 values-4]
diff --git 
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
 
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
index 17ba2e0..077fdfe 100644
--- 
a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
+++ 
b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/annotation/Column.java
@@ -102,8 +102,8 @@ public @interface Column {
     AnalyzerType analyzer() default AnalyzerType.OAP_ANALYZER;
 
     /**
-     * Sharding key is used to group time series data per metric of one entity 
in one place (same sharding or same
-     * column for column-oriented database).
+     * Sharding key is used to group time series data per metric of one entity 
in one place (same sharding and/or same
+     * row for column-oriented database).
      * For example,
      * ServiceA's traffic gauge, service call per minute, includes following 
timestamp values, then it should be sharded
      * by service ID

Reply via email to