wu-sheng commented on pull request #7: URL: https://github.com/apache/skywalking-rover/pull/7#issuecomment-1073263148
> > This PR includes some generated files and binary files, can you elaborate why they have to be checked in the codebase instead of generated at build time? > > Now we are using the `github.com/cilium/ebpf/cmd/bpf2go` for helping build the binary with generating code, working on BPF CO-RE. It generates the BPF skeleton with code that works with our code(rover side). So we need to pre-generate the code before running and compiling the code. > > Also, I think if we don't want to check in the codebase, we could let git ignore them. Then, generate them when we build rover or just checkout rover and debugging. Yes, I think ignoring the generated codes locally would be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
