Cool-Coding commented on a change in pull request #8719:
URL: https://github.com/apache/skywalking/pull/8719#discussion_r830813063
##########
File path: test/e2e-v2/cases/so11y/so11y-cases.yaml
##########
@@ -30,7 +30,7 @@
expected: expected/metrics-has-value.yml
- query: swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphql metrics linear
--name=meter_oap_instance_trace_count --instance-name=http://localhost:1234
--service-name=oap::oap-server |yq e 'to_entries' -
expected: expected/metrics-has-value.yml
- - query: swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphql metrics linear
--name=meter_oap_instance_metrics_first_aggregation
--instance-name=http://localhost:1234 --service-name=oap::oap-server |yq e
'to_entries' -
+ - query: swctl --display yaml
--base-url=http://${oap_host}:${oap_12800}/graphql metrics linear
--name=meter_oap_instance_metrics_aggregation
--instance-name=http://localhost:1234 --service-name=oap::oap-server |yq e
'to_entries' -
Review comment:
> You are changing `single value` -> `labeled value`, I assume the
expected file should be updated too.
I am not familiar with `e2e-solly`. Take a moment, I will look at it.
Thanks for your reminder and patience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
