mrproliu commented on pull request #7: URL: https://github.com/apache/skywalking-rover/pull/7#issuecomment-1073633216
> Let me sum up the (major) needed changes in this PR: > > * [ ] `make container-all` doesn't run everything inside a container, for example the `build` is still running in local machine, thus it fails when there is no `llvm-strip-13` installed. Update `container-all` to generate the code in a container, and make it in the local machine. The E2E split commands to run. > * [ ] files under `bpf/include` are unnecessary, these headers should be pre-installed by the users, via something like `apt install -y libbpf-dev`. And should be documented in the prerequisites in the build documentation. I see what you mean. I have created a customized container to link what we need in the compilation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
