[GitHub] [skywalking] qxo edited a comment on issue #3068: improve ContextManager.stopSpan performance: call ThreadLocal only once

[GitBox]

qxo edited a comment on issue #3068: improve ContextManager.stopSpan 
performance: call ThreadLocal only once
URL: https://github.com/apache/skywalking/pull/3068#issuecomment-511205721
 
 
   the ThreadLocalGetXTimeBenchmark  code:
   ```
   import java.util.concurrent.TimeUnit;
   
   import org.openjdk.jmh.annotations.Benchmark;
   import org.openjdk.jmh.annotations.BenchmarkMode;
   import org.openjdk.jmh.annotations.Fork;
   import org.openjdk.jmh.annotations.Measurement;
   import org.openjdk.jmh.annotations.Mode;
   import org.openjdk.jmh.annotations.OutputTimeUnit;
   import org.openjdk.jmh.annotations.Scope;
   import org.openjdk.jmh.annotations.State;
   import org.openjdk.jmh.annotations.Warmup;
   import org.openjdk.jmh.runner.Runner;
   import org.openjdk.jmh.runner.RunnerException;
   import org.openjdk.jmh.runner.options.Options;
   import org.openjdk.jmh.runner.options.OptionsBuilder;
   import org.openjdk.jmh.runner.options.TimeValue;
   
   @Fork(5)
   @Warmup(iterations = 5,time = 1,timeUnit = TimeUnit.SECONDS)
   @Measurement(iterations = 10,time = 1,timeUnit = TimeUnit.SECONDS)
   @BenchmarkMode(Mode.Throughput)
   @OutputTimeUnit(TimeUnit.MILLISECONDS)
   @State(Scope.Benchmark)
   public class ThreadLocalGetXTimeBenchmark {
   
       private static class Bean {
           private String name = "ABC";
   
           public String getName() {
               return name;
           }
   
           public void setName(String name) {
               this.name = name;
           }
   
           public String stop(Bean bean) {
               return bean.getName();
           }
       }
       private static final ThreadLocal<Bean> CONTEXT = new ThreadLocal<Bean>() 
{
   
           @Override
           protected Bean initialValue() {
               return new Bean();
           }
   
       };
   
       protected String stop(Bean bean) {
           return bean.stop(bean);
       }
   
   
       @Benchmark
       public String getThreadLocalTwice() {
           return get().stop(get());
       }
   
       @Benchmark
       public String getThreadLocalFourTime() {
           get();
           get();
           get();
           get();
           return get().stop(get());
       }
   
       @Benchmark
       public String getThreadLocalOnce1() {
           final Bean bean = get();
           return bean.stop(bean);
       }
   
   //@Benchmark
       public String getThreadLocalOnce2() {
           return stop(get());
       }
   
   
       protected Bean get() {
           return CONTEXT.get();
       }
   
       public static void main(String[] args) throws RunnerException {
           Options opt = new 
OptionsBuilder().include(ThreadLocalGetXTimeBenchmark.class.getSimpleName())
               .mode(Mode.Throughput)
               .warmupIterations(8).measurementIterations(8).forks(0)
               
.measurementTime(TimeValue.seconds(1)).warmupTime(TimeValue.seconds(1))
               .threads(4)
               .timeUnit(TimeUnit.MILLISECONDS)
               .build();
           new Runner(opt).run();
       }
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services