jlstephens89 commented on a change in pull request #8769:
URL: https://github.com/apache/skywalking/pull/8769#discussion_r838634666
##########
File path: .lift/config.toml
##########
@@ -1,3 +1,8 @@
jdk11 = true
-ignoreRules = [ "THREAD_SAFETY_VIOLATION", "MissingSummary",
"SameNameButDifferent" ]
+ignoreRules = [ "THREAD_SAFETY_VIOLATION", "MissingSummary",
"SameNameButDifferent", "NonAtomicVolatileUpdate", "EqualsGetClass"]
setup = ".lift/setup.sh"
+ignoreFiles = """
+skywalking-ui/
+apm-protocol/apm-network/target/
Review comment:
Makes sense.
I've added generated sources
https://github.com/apache/skywalking/pull/8769/commits/9902e290de934f211e88ffbd2d4e99bb2f01d4f5
For safety I've also excluded any target directory
https://github.com/apache/skywalking/pull/8769/commits/5b398d558f19e3419bf7de79bdfade3330c46f21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
