kezhenxu94 commented on a change in pull request #97:
URL: https://github.com/apache/skywalking-eyes/pull/97#discussion_r839110272
##########
File path: pkg/config/config.go
##########
@@ -22,15 +22,17 @@ import (
"github.com/apache/skywalking-eyes/assets"
"github.com/apache/skywalking-eyes/internal/logger"
+ "github.com/apache/skywalking-eyes/pkg/comments"
"github.com/apache/skywalking-eyes/pkg/deps"
"github.com/apache/skywalking-eyes/pkg/header"
"gopkg.in/yaml.v3"
)
type Config struct {
- Header header.ConfigHeader `yaml:"header"`
- Deps deps.ConfigDeps `yaml:"dependency"`
+ Header header.ConfigHeader `yaml:"header"`
+ Deps deps.ConfigDeps `yaml:"dependency"`
+ Languages map[string]comments.Language `yaml:"language"`
Review comment:
This config should be under `Header`
##########
File path: .licenserc.yaml
##########
@@ -83,3 +83,18 @@ header: # `header` section is configurations for source
codes license header.
dependency:
files:
- go.mod
+
+language:
+ Go:
+ type: programming
+ color: "#00ADD8"
+ aliases:
+ - golang
+ extensions:
+ - ".go"
+ tm_scope: source.go
+ ace_mode: golang
+ codemirror_mode: go
+ codemirror_mime_type: text/x-go
+ language_id: 132
+ comment_style_id: SlashAsterisk
Review comment:
Please minimize the configs, we only need some of the fields, like
`comment_style_id` and `extensions`,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
