wu-sheng commented on issue #3035: NPE Aspect
URL: https://github.com/apache/skywalking/issues/3035#issuecomment-511255548
 
 
   @candyleer In the old day(not in SkyWalking), I check about how to do Spring 
Controller plugin, the reason of `EnhancedInstance` is that there is no place 
to put mapping path cache, so most likely, you have to maintain a static map to 
do so, which cause the performance concern in big system(10k+ Controller 
methods at least)
   
   I am totally aware this kind of OP has risk, but, actually, if we consider 
this risk, we can't do anything at any class because any class could be added 
in Spring context by the end user, we don't know.
   
   This is why we added Spring patch at first place, could you try to enhance 
it rather than provide a plugin or remove this field? I am going to open a new 
issue to discuss this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to