qxo commented on issue #3073: fixed for asyncFinishLock: avoid call finish more than once URL: https://github.com/apache/skywalking/pull/3073#issuecomment-511257546 1. set breakpoint before call checkFinishConditions and inside checkFinishConditions, then try in debug mode,asyncStop in other thread(pause before checkFinishConditions ), let stopSpan pop make activeSpanStack to empty first,... 2. It's hard reproduct without codeline debug 3. I'll do the demo if have the time 4. In my point of view: The method(checkFinishConditions) code do not change program(object) state,the asyncFinishLock is useless if it's not a problem. ===> 理论上一个方法内部没改状态且程序又依赖于其返回值，方法内部加锁是不正确的使用方式：因为多线程在同时请求checkFinishConditions时就会出问题 如有不对，请指:)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
