candyleer opened a new pull request #3080: Add aspectJ patch to fix 
PointcutExpression match issue
URL: https://github.com/apache/skywalking/pull/3080
 
 
   Please answer these questions before submitting pull request
   
   - Why submit this pull request?
   - [x] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   #3035 
   #3076
   ___
   ### Bug fix
   - Bug description.
    like other patch,when spring-aop match the pointcut expression,we exclude 
the skywaking echance-instance method which make spring-aop work like  without 
skywalking-agent way.
   
   
   - How to fix?
   from the source code, spring aop `Advisor ` consist of `PointcutAdvisor`(for 
methods in class aop) and `InstructionAdvisor` (for only classes aop),so we 
only exclude the matches from pointcut by enhancing  
`org.springframework.aop.aspectj.AspectJExpressionPointcut.matches`
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to