wu-sheng commented on code in PR #146:
URL: https://github.com/apache/skywalking-java/pull/146#discussion_r844927891
##########
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java:
##########
@@ -234,4 +235,12 @@ static void configureLogger() {
LogManager.setLogResolver(new PatternLogResolver());
}
}
+
+ public static void pluginInitCompleted() {
+ IS_PLUGIN_INIT_COMPLETED = true;
+ }
+
+ public static boolean isPluginInitCompleted() {
+ return IS_PLUGIN_INIT_COMPLETED;
+ }
Review Comment:
Also, if you need a new flag of plugin initialization, it looks like the
flag should be in `PluginFinder`?
[SnifferConfigInitializer.java](https://github.com/apache/skywalking-java/pull/146/files/22e85142ff56493cee90adf49d123b71ff3e0089#diff-3f4c9264a89197350b7eb2ca0e2f2daa494306980a00142edef7f5abfc941951)
seems a wrong place to add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
